Formfields: Add ability to set attributes to <input> Tag#807
Merged
PhilippGrashoff merged 9 commits intoatk4:developfrom Sep 27, 2019
Merged
Formfields: Add ability to set attributes to <input> Tag#807PhilippGrashoff merged 9 commits intoatk4:developfrom
PhilippGrashoff merged 9 commits intoatk4:developfrom
Conversation
New property added: $this->inputAttr in which additional attributes are stored New function added: setInputAttr() which is a clone of View->setAttr() which fills the $this->inputAttr array Can also be used to overwrite existing attributes as $this->inputAttr is passed as second param to array_merge (at $this->app->getTag())
Codecov Report
@@ Coverage Diff @@
## develop #807 +/- ##
=============================================
+ Coverage 76.23% 76.28% +0.04%
- Complexity 2291 2293 +2
=============================================
Files 119 119
Lines 5404 5414 +10
=============================================
+ Hits 4120 4130 +10
Misses 1284 1284
Continue to review full report at Codecov.
|
romaninsh
approved these changes
Sep 27, 2019
abbadon1334
approved these changes
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, only attributes could be set to the surrounding
New property added: $this->inputAttr in which additional attributes are stored
New function added: setInputAttr() which is a clone of View->setAttr() which fills the $this->inputAttr array
Can also be used to overwrite existing attributes as $this->inputAttr is passed as second param to array_merge (at $this->app->getTag())