You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@abbadon1334 that was my thought also, but after testing I see that it doesn't behave exactly like TypeString as the column expands at maximum width. So the exception is indeed fixed but there should be an additional fix to make it work like string. I suspect the factoryType() function within FilterModel\Generic. Will take a look at it if I have time. @karakal if you have the time to spot and fix this, go ahead.
OK, so this is by design. ATK assigns an atk-cell-expanded class in TableColumn\Text.php. This is what makes it look different, and for a text field this is logical. So merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Fix of
Error in addFilterColumn(see ticket #805 ).