Conversation
it's impossible to add it in later phase
romaninsh
approved these changes
Aug 31, 2018
Member
|
it appears we need to observe in any case :) maybe it should be in the modal itself..? |
Member
Author
|
I would vote "YES" on that, but bad thing is that it's impossible to nicely remove that option if in some case we don't need it at all. |
Codecov Report
@@ Coverage Diff @@
## develop #553 +/- ##
=============================================
+ Coverage 65.7% 65.91% +0.21%
Complexity 1631 1631
=============================================
Files 91 91
Lines 3901 3902 +1
=============================================
+ Hits 2563 2572 +9
+ Misses 1338 1330 -8
Continue to review full report at Codecov.
|
Member
|
It could be a property you specify to constructor... |
Member
|
fixed travis and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's impossible to add it in later phase