Skip to content

Add loadable typecast for JsCallback arguments#2225

Merged
mvorisek merged 26 commits intodevelopfrom
impl_js_loadable_value
Nov 23, 2024
Merged

Add loadable typecast for JsCallback arguments#2225
mvorisek merged 26 commits intodevelopfrom
impl_js_loadable_value

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Nov 20, 2024

Newly the passed arguments for JsCallback must define also "load typecasting".

This way we ensure the values passed to the given function passed to JsCallback are always already typecasted and with the right typecasting method for the generating source.

If values are passed as not-JsExpressionable thru View::on, they are bidirectionally typecasted implicitly.

@mvorisek mvorisek added the MAJOR label Nov 20, 2024
@mvorisek mvorisek force-pushed the impl_js_loadable_value branch 29 times, most recently from ef8a1f2 to a3e8e54 Compare November 22, 2024 01:22
@mvorisek mvorisek force-pushed the impl_js_loadable_value branch from 87e42bd to dedc9ee Compare November 22, 2024 22:35
@mvorisek mvorisek merged commit c480f98 into develop Nov 23, 2024
@mvorisek mvorisek deleted the impl_js_loadable_value branch November 23, 2024 21:24
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants