Add "smallint" and "bigint" support to FilterModel#2211
Merged
mvorisek merged 19 commits intoatk4:developfrom Jun 18, 2024
Merged
Add "smallint" and "bigint" support to FilterModel#2211mvorisek merged 19 commits intoatk4:developfrom
mvorisek merged 19 commits intoatk4:developfrom
Conversation
Member
|
Well, it is not strictly a bug, but I will say the impact is not minimal as all IDs are bigint by default since v5.2. Please investigate on what simplest demo the ID can be filtered and tested. We need a test before we merge it. |
…nto fix_filter_model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2210 and wrapped numeric type filtering in general
related with atk4/data#1223 and #2208