Fix number input type for values over 1000#2163
Merged
Conversation
06f140e to
4da2d4b
Compare
4da2d4b to
a3f39b7
Compare
a3f39b7 to
9e65828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI numeric values/types are rendered using UI persistence and can contain non-numeric characters like space, comma.
repro
Currently, such correctly formatted UI values, are considered as bad, example:
can be reproduced on
demos/form-control/multiline.phpdemo by writing1 000in "Qty" number input.solution
The visual style is controlled by https://developer.mozilla.org/en-US/docs/Web/CSS/:invalid CSS presudo class which is set by https://developer.mozilla.org/en-US/docs/Web/HTML/Constraint_validation . In short, input
type=numbercannot be used for anything else than\d+value, thus we need to settypeto be different thannumberor do not set it at all.