Prevent JsCallback chain to be evaluated twice#2150
Merged
Conversation
f27dbb9 to
aa69390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the introduction - https://github.com/atk4/ui/blob/90b0fcecdc/src/jsCallback.php#L21 - the JS chain was allowed to be mutated (like
$jquery->xxx()) and if so, it was automatically appended to the response.But all usages and demos also return the JS chain!
This was a problem, as the returned JS chain was added to the response as well, so the JS chain was evaluated twice!
Now we fix it by no longer adding the JS chain to the response, instead, we require the JS chain to be returned it if it was mutated.
repro: https://github.com/atk4/ui/blob/5.0.0/demos/javascript/js.php#L60
before:
after: