Skip to content

Drop $useRequestUrl param from App::url() method#2107

Merged
mvorisek merged 1 commit intodevelopfrom
drop_use_request_url
Sep 14, 2023
Merged

Drop $useRequestUrl param from App::url() method#2107
mvorisek merged 1 commit intodevelopfrom
drop_use_request_url

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Sep 14, 2023 •
edited
Loading

if needed, just pass the dropped code as $page argument

also note the dropped code can be written as non-string as:

$request = $app->getRequest();
$page = [0 => $request->getUri()->getPath()] + $request->getQueryParams();

@mvorisek mvorisek marked this pull request as ready for review September 14, 2023 20:59
@mvorisek mvorisek mentioned this pull request Sep 14, 2023
Merged
@mvorisek mvorisek merged commit f1277b7 into develop Sep 14, 2023
@mvorisek mvorisek deleted the drop_use_request_url branch September 14, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BC-break

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvorisek