View::set() can be used to set content property only#2075
Merged
Conversation
364278f to
0b5f5f0
Compare
02e8875 to
d8c601d
Compare
d8c601d to
b19ccad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View::set()method was historically coded to support too many usecases which made it very hard to override and satisfy LSP.Weak static analysis also allowed #2016 bug.
Thankfully, at least in atk4/ui, the misuse count was low.
The replacement is
$this->template->set()and$this->setDefaults()(or$this->property = value) depending on the usecase.