Skip to content

Remove no longer needed JS API data clear#1963

Merged
mvorisek merged 1 commit intodevelopfrom
no_data_clear
Jan 8, 2023
Merged

Remove no longer needed JS API data clear#1963
mvorisek merged 1 commit intodevelopfrom
no_data_clear

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Jan 7, 2023 •
edited
Loading

introduced in #909

probably related/fixed with fomantic/Fomantic-UI#2581

I have verified the #902 is NOT reintroduced, test code:

$form = \Atk4\Ui\Form::addTo($app);
$form->addControl('purge_missing', [\Atk4\Ui\Form\Control\Checkbox::class]);
$form->buttonSave->set('Import');

$form->onSubmit(function(\Atk4\Ui\Form $form) {
    throw new \Exception((string) $form->model->get('purge_missing'));
});

(and tested by probably some Behat test already)

@mvorisek mvorisek marked this pull request as draft January 7, 2023 23:27
@mvorisek mvorisek marked this pull request as ready for review January 8, 2023 00:41
@mvorisek mvorisek merged commit 038862c into develop Jan 8, 2023
@mvorisek mvorisek deleted the no_data_clear branch January 8, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvorisek