Unimplement JsExpressionable from View#1957
Merged
Conversation
091a682 to
fff7811
Compare
fff7811 to
15115a3
Compare
fbb6d18 to
71b88f7
Compare
95ff375 to
a2ed154
Compare
926e0a7 to
8afecf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent bad use of
View, the ID is never an invokeable expression, we we can thread it like other literals when renderingBC break only when
Viewwas rendered thru some custom JS renderer (rare)ViewID was obtained thru calling$view->jsRender()directly (never recommended, passViewinstance toJsExpressiondirectly)