Fix modal error handling when opening#1925
Merged
Conversation
9fbd983 to
1cf1641
Compare
1cf1641 to
93cbfac
Compare
83564c7 to
1c78497
Compare
cc73b01 to
0deb334
Compare
This was referenced Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the error handling topic is quite complex,
closeOnLoadingErrormodal data variable is newly set when the modal is to be opened for the first time from API, once the load is complete, the variable is removed.Any inner modal must NOT close any parent modal! (checked in JS code, JS exception in console will be thrown, but the modal will never be closable by an user then)