Enforce global Fomantic-UI settings#1917
Merged
Conversation
bf45413 to
e8272e9
Compare
e8272e9 to
58c4250
Compare
bcbe782 to
d898795
Compare
fe6fffe to
3a87b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
js/src/setup-fomantic-ui.jswe override some global settings (like$.fn.api.settings.onSuccess) and we rely on it, so we must prevent additional override by developer when creating specific Fomantic-UI moduleapi callbacks overrides are supported, original & custom callback is called
related fomantic/Fomantic-UI#2526