Skip to content

Upgrade Vue.js to v3 and drop IE11 support#1915

Merged
mvorisek merged 25 commits intodevelopfrom
upgrade_vue3
Nov 28, 2022
Merged

Upgrade Vue.js to v3 and drop IE11 support#1915
mvorisek merged 25 commits intodevelopfrom
upgrade_vue3

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Oct 25, 2022 •
edited
Loading

Major version upgrades:

css-loader                        ^5.2.6  →    ^6.7.1
mitt                              ^2.1.0  →    ^3.0.0
style-loader                      ^2.0.0  →    ^3.3.1
vue                              ^2.6.14  →   ^3.2.41
vue-flatpickr-component           ^8.1.7  →   ^10.0.0
vue-loader                       ^15.9.7  →   ^17.0.0
vue-template-compiler            ^2.7.13  →   removed
vue-flatpickr-component           ^8.1.7  →   ^10.0.0
semantic-ui-vue                  ^0.11.0  →   removed
vue-fomantic-ui                    added  →   ^0.13.0
vue-flatpickr-component           ^8.1.7  →   ^10.0.0
vue-query-builder                 ^0.8.2  →   github:TheAustinG/vue-query-builder#2f5c4408e3

multiline/vue dropdown API filtering to be fixed later - #1940

BC break: we also drop IE11 support officially (as no longer supported by vue3 - https://stackoverflow.com/questions/64836337/using-vue-3-in-ie11#64837153)

@mvorisek mvorisek force-pushed the upgrade_vue3 branch 4 times, most recently from 9fea835 to 836932d Compare October 29, 2022 08:39
@mvorisek mvorisek force-pushed the upgrade_vue3 branch 4 times, most recently from 8013c79 to 6ac4a7c Compare November 5, 2022 14:50
@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Nov 7, 2022

Hi @ibelar, would you be please so kind and look at the vue3 upgrade?

@ibelar
Copy link
Copy Markdown
Contributor

ibelar commented Nov 7, 2022

Hi @ibelar, would you be please so kind and look at the vue3 upgrade?

Upgrading to Vue 3 will not be possible until Semantic-Ui vue is upgrade as well or completely refactoring component that use it.

@mvorisek mvorisek changed the title Upgrade all JS deps to the latest major version Upgrade Vue.js to v3 Nov 13, 2022
@mvorisek mvorisek added the MAJOR label Nov 13, 2022
@mvorisek mvorisek force-pushed the upgrade_vue3 branch 15 times, most recently from 0e41dce to f28aff5 Compare November 18, 2022 17:56
@mvorisek mvorisek force-pushed the upgrade_vue3 branch 2 times, most recently from 197038d to bf70080 Compare November 23, 2022 17:08
@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Nov 24, 2022 •
edited
Loading

@ibelar I have managed to upgrade Vue to v3, but I have to admit it was not easy - how much do your apps use custom vue? Would you be ok to have this PR in the next major stable atk4/ui release, or should we release v4.0 first and then tag 4.1 for easier migration?

@mkrecek234
Copy link
Copy Markdown
Contributor

mkrecek234 commented Nov 25, 2022

@mvorisek Great, thank you! Even though I am not using a lot of Vue components (only very few) I see that a lot of Vue libraries out there are still in the process of being migrated to v3 - I personally would opt for the 4.1 release for Vue v3 to make upgrade paths more flexible. Too many great improvements beyond Vue v3 so far in Atk4 to bundle them in one release.

@mvorisek mvorisek changed the title Upgrade Vue.js to v3 Upgrade Vue.js to v3 and drop IE11 support Nov 27, 2022
@mvorisek mvorisek mentioned this pull request Nov 28, 2022
Open
@mvorisek mvorisek mentioned this pull request Nov 28, 2022
Open
@mvorisek mvorisek marked this pull request as ready for review November 28, 2022 13:02
@mvorisek mvorisek merged commit dedb4ce into develop Nov 28, 2022
@mvorisek mvorisek deleted the upgrade_vue3 branch November 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

MAJOR

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvorisek @ibelar @mkrecek234