Refactor JS code and improve coverage#1894
Merged
Conversation
3f54277 to
c36bd90
Compare
f41fabc to
73ef101
Compare
696b100 to
bfc8193
Compare
6924b6e to
627232a
Compare
627232a to
facfadb
Compare
facfadb to
7abdcdf
Compare
d098046 to
a76dfa2
Compare
c1a5f01 to
ec5954f
Compare
12301fd to
e5d0dc5
Compare
e5d0dc5 to
b75fe51
Compare
This reverts commit 1ad834b.
2ac46a8 to
4d590bb
Compare
4d590bb to
5d50343
Compare
ad8e473 to
32ee166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1891 and #1892
BC break: all
urioptions (and relateduriOptions) were renamed tourlthe removed/refactored JS code is expected not to be used in user code thus no changes should be required, if somethimg broke your code, see individual commits for all changes