Skip to content

HTML5 void tag App::getTag() aware handling#1884

Merged
mvorisek merged 12 commits intodevelopfrom
fix_xhtml_self_closing
Oct 5, 2022
Merged

HTML5 void tag App::getTag() aware handling#1884
mvorisek merged 12 commits intodevelopfrom
fix_xhtml_self_closing

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Oct 5, 2022 •
edited
Loading

https://developer.mozilla.org/en-US/docs/Glossary/Void_element

regex:

(?<=<|</)(?<=/|(?=[^<>]+/>))(area|base|br|col|embed|hr|img|input|link|meta|param|source|track|wbr)

@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch from 1fcf5aa to f0f6f57 Compare October 5, 2022 11:20
@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch from f0f6f57 to c02ec94 Compare October 5, 2022 11:57
@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch from 8bc48fe to 17adc4b Compare October 5, 2022 12:47
@mvorisek mvorisek changed the title Fix self closing tags for xhtml compatibility Do not render self-closing slash for HTML5 Oct 5, 2022
@mvorisek mvorisek changed the title Do not render self-closing slash for HTML5 Fix self-closing slash for HTML5 Oct 5, 2022
@mvorisek mvorisek changed the title Fix self-closing slash for HTML5 Fix self-closing tags for HTML5 Oct 5, 2022
@mvorisek mvorisek changed the title Fix self-closing tags for HTML5 HTML5 void tag App::getTag() aware handling Oct 5, 2022
@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch 2 times, most recently from 844b4ef to af2f217 Compare October 5, 2022 19:57
@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch from af2f217 to 60e455f Compare October 5, 2022 19:59
@mvorisek mvorisek marked this pull request as ready for review October 5, 2022 20:00
@mvorisek mvorisek force-pushed the fix_xhtml_self_closing branch from c208cdb to e5b0044 Compare October 5, 2022 21:09
@mvorisek mvorisek merged commit 001b4de into develop Oct 5, 2022
@mvorisek mvorisek deleted the fix_xhtml_self_closing branch October 5, 2022 21:26
@mvorisek mvorisek mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

@acicovic acicovic Awaiting requested review from acicovic

@georgehristov georgehristov Awaiting requested review from georgehristov

@ibelar ibelar Awaiting requested review from ibelar

@mkrecek234 mkrecek234 Awaiting requested review from mkrecek234

Assignees

No one assigned

Labels

BC-break enhancement 👍

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvorisek