Skip to content

Fix many missing/wrong types#1831

Merged
mvorisek merged 38 commits intodevelopfrom
improve_phpstan
Aug 24, 2022
Merged

Fix many missing/wrong types#1831
mvorisek merged 38 commits intodevelopfrom
improve_phpstan

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Aug 22, 2022 •
edited
Loading

BC breaks:

  • renamed Atk4\Ui\Item to Atk4\Ui\MenuItem
  • renamed Atk4\Ui\Step to Atk4\Ui\WizardStep
  • renamed Atk4\Ui\Tab to Atk4\Ui\TabsTab
  • some overriding method prototypes need to be changed to satisfy LSP

there are tons of changes, but the breaking impact to your code should be none or minimal

@mvorisek mvorisek marked this pull request as ready for review August 22, 2022 02:21
@mvorisek mvorisek changed the title improve seed/decorator phpstan types Improve seed/decorator phpstan types Aug 22, 2022
@mvorisek mvorisek force-pushed the improve_phpstan branch 2 times, most recently from 1663f2e to ee0e1af Compare August 22, 2022 13:10
@mvorisek mvorisek changed the title Improve seed/decorator phpstan types Improve phpstan types Aug 22, 2022
@mvorisek mvorisek changed the title Improve phpstan types Fix missing/wrong types Aug 22, 2022
@mvorisek mvorisek changed the title Fix missing/wrong types Fix many missing/wrong types Aug 23, 2022
@mvorisek mvorisek mentioned this pull request Aug 23, 2022
Merged
@mvorisek mvorisek merged commit 01d39d2 into develop Aug 24, 2022
@mvorisek mvorisek deleted the improve_phpstan branch August 24, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BC-break

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvorisek