Drop $class param from View constructor#1791
Merged
Conversation
b3a0f70 to
3ada5b7
Compare
3ada5b7 to
83d9a20
Compare
a7ca761 to
490fb37
Compare
ad248b4 to
d869b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in favor of
class.xxxseed syntax introduced in #1770this change intends to make the code more readable and error proof
to find most places to update, use
\[\s*+[^\[\]]+(?<!=> )'(\w| )+'(?! =>)regex