Bundle all external assets (/wo twemoji)#1785
Merged
Conversation
36d565e to
dfde81b
Compare
dfde81b to
dac3f64
Compare
8f3318b to
a1c08b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace & repush of #1782, no twemoji icons (reduce repo size by about 3500 files / 25 MB)
other resources are carefully selected (like we do not need to bundle other fonts than WOFF2)
fixes #1025
external Google Fonts will be bundled in a separate PR (#1784)
temporary,
App::cdnpaths must be adjusted! - public URL discovery will be added in a separate PRexample temporary fix of your app to be put to the code where you create/init your App instance: