Skip to content

Fix datetime grid filter bug on empty input#1718

Merged
mvorisek merged 3 commits intoatk4:developfrom
mkrecek234:bug/fix_grid_datetime_filter
Dec 6, 2021
Merged

Fix datetime grid filter bug on empty input#1718
mvorisek merged 3 commits intoatk4:developfrom
mkrecek234:bug/fix_grid_datetime_filter

Conversation

@mkrecek234
Copy link
Copy Markdown
Contributor

@mkrecek234 mkrecek234 commented Dec 5, 2021

@mvorisek As requested, sorry for the earlier PR - solves issue #1717

@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Dec 5, 2021

next time, better to keep the same PR...

how to test: issue can be tested on collection/tablefilter.php demo by replacing CountryLock with Stat

this PR is bad, a) this does not fix the same issue in other Dt filters (TypeDate, TypeDateTime, TypeTime), b) code of these filters should be deduplicated

@mkrecek234
Copy link
Copy Markdown
Contributor Author

mkrecek234 commented Dec 5, 2021 •
edited
Loading

@mvorisek Sorry, but I try just to help fixing bugs even if it is not as exhaustive as you would fancy (to your point that PR is "bad"). I think contributing should not be criticised as "bad" or "good". Every contribution identifying or fixing even the most minor bug should be considered "helpful". If you can make it even better, e.g., by even improving code by deduplicating, everyone will appreciate this a lot.

Please check commit for datetime fixing the same issue

@mvorisek mvorisek merged commit 987c9f2 into atk4:develop Dec 6, 2021
@mvorisek mvorisek mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkrecek234 @mvorisek