Skip to content

Add filtering possibility for float and atk4_money DBAL types#1703

Merged
mvorisek merged 3 commits intoatk4:developfrom
mkrecek234:develop
Nov 29, 2021
Merged

Add filtering possibility for float and atk4_money DBAL types#1703
mvorisek merged 3 commits intoatk4:developfrom
mkrecek234:develop

Conversation

@mkrecek234
Copy link
Copy Markdown
Contributor

@mkrecek234 mkrecek234 commented Nov 24, 2021

Please add these missing filters for table columns

@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Nov 24, 2021

I prefer to register TypeNumber class to handle the float/atk4_money types instead.

@mkrecek234
Copy link
Copy Markdown
Contributor Author

mkrecek234 commented Nov 24, 2021

It auto-references the Filter today towards FilterAtk4_money, so in case this is missing, no filtered grid will work. I would prefer to include by now, so grid supports any field type and is not throwing errors.

@mvorisek mvorisek changed the title Filter for Float and Atk4_money Add filtering possibility for float and atk4_money DBAL types Nov 24, 2021
@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Nov 26, 2021

@mkrecek234 please test

@mkrecek234
Copy link
Copy Markdown
Contributor Author

mkrecek234 commented Nov 29, 2021

@mvorisek Tested and working👍

@mvorisek mvorisek merged commit 5954556 into atk4:develop Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

waiting for author

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkrecek234 @mvorisek