Skip to content

Adjust to non-entity Field only#1692

Merged
mvorisek merged 31 commits intodevelopfrom
stricter_model_vs_entity
Nov 11, 2021
Merged

Adjust to non-entity Field only#1692
mvorisek merged 31 commits intodevelopfrom
stricter_model_vs_entity

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Nov 6, 2021

related with atk4/data#912 changes

BC break

a) Form\Control::$field renamed to $entityField with new Atk4\Data\Model\EntityFieldPair type
b) some atk4/ui methods were simplified (for example to not accept vague string seed), use phpstan with level 6+ on your project to detect the needed changes

@mvorisek mvorisek changed the title Adjust to model only Field Adjust to non-entity Field only Nov 6, 2021
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch 13 times, most recently from 6919f17 to 3be967a Compare November 7, 2021 11:20
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch 4 times, most recently from e2c2508 to c03a471 Compare November 7, 2021 15:48
@mvorisek mvorisek marked this pull request as ready for review November 7, 2021 15:59
@mvorisek mvorisek added the RTM label Nov 7, 2021
@mvorisek mvorisek removed the RTM label Nov 7, 2021
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch from 2141477 to c72927a Compare November 7, 2021 17:33
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch from 7dc9e44 to b47b515 Compare November 8, 2021 22:01
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch from 49583ff to d418e10 Compare November 10, 2021 13:27
@mvorisek mvorisek force-pushed the stricter_model_vs_entity branch from 552c94d to f93e35f Compare November 10, 2021 13:35
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for 3.1

@mvorisek mvorisek merged commit 81b776f into develop Nov 11, 2021
@mvorisek mvorisek deleted the stricter_model_vs_entity branch November 11, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants