Skip to content

Fix DB config for CI webserver started with one env#1683

Merged
mvorisek merged 6 commits intodevelopfrom
fix_db_config_behat
Oct 20, 2021
Merged

Fix DB config for CI webserver started with one env#1683
mvorisek merged 6 commits intodevelopfrom
fix_db_config_behat

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Oct 19, 2021

previously, Behat was tested with Sqlite only

merge after atk4/data#908

@mvorisek mvorisek requested a review from DarkSide666 October 19, 2021 09:44
@mvorisek mvorisek added the RTM label Oct 19, 2021
@mvorisek mvorisek force-pushed the fix_db_config_behat branch from 8b09dc5 to b7ecbca Compare October 19, 2021 10:20
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behat test fails

@mvorisek
Copy link
Copy Markdown
Member Author

👍 @DarkSide666 for noticing the CI error, I belive the PgSQL Behat is failing really because of some DB specific issue.

@mvorisek mvorisek marked this pull request as draft October 19, 2021 13:41
@mvorisek mvorisek force-pushed the fix_db_config_behat branch 2 times, most recently from 8cb359c to 275889f Compare October 20, 2021 00:49
@mvorisek mvorisek marked this pull request as ready for review October 20, 2021 01:02
@mvorisek mvorisek force-pushed the fix_db_config_behat branch from 275889f to c1ea0e4 Compare October 20, 2021 01:09
@mvorisek mvorisek removed the RTM label Oct 20, 2021
@mvorisek mvorisek force-pushed the fix_db_config_behat branch 2 times, most recently from e382b9d to 0459e56 Compare October 20, 2021 11:37
@mvorisek mvorisek added the RTM label Oct 20, 2021
@mvorisek mvorisek force-pushed the fix_db_config_behat branch from 0459e56 to ef8a6b2 Compare October 20, 2021 11:50
@mvorisek mvorisek merged commit 5d62861 into develop Oct 20, 2021
@mvorisek mvorisek deleted the fix_db_config_behat branch October 20, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants