Conversation
Contributor
|
I will check. Should I push fix to this branch?
…On Tue, Oct 5, 2021 at 10:43 AM Michael Voříšek ***@***.***> wrote:
@ibelar <https://github.com/ibelar> one unit test fix is needed, also
please check
https://github.com/atk4/ui/blob/4bf8f12c4c72fcf21a3666b3007b081aeba6ba99/src/VirtualPage.php#L152
, not sure if Modals here needs any care too
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1670 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ2GPWPSEJW7RYOTA5KBHTUFMFKPANCNFSM5FLZE26A>
.
--
Alain Belair
|
Member
Author
Yes, small almost typo fix. Also, I wonder about the Right Panel name. What about Side Panel name instead? I belive it can be easily configured to be on the left side as well. |
Contributor
|
Make sense to rename to Side Panel.
I push fix to your branch.
- remove modal rendering from VirtualPage
- add test that check for Modal inside VP
I saw there is an issue with Column Filter. I believe it has to do with
data validation since DBAL is in place.
Not sure where to look for
Got to go now.
…On Tue, Oct 5, 2021 at 4:21 PM Michael Voříšek ***@***.***> wrote:
I will check. Should I push fix to this branch?
Yes, small almost typo fix.
Also, I wonder about the Right Panel name. What about Side Panel name
instead? I belive it can be easily configured to be on the left side.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1670 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ2GPTF25LWQVIHHQKGIVLUFNM27ANCNFSM5FLZE26A>
.
--
Alain Belair
|
Member
Author
|
Tests are passing, let's merge this fix. If there is any DBAL issue, please let me know and I can fix quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.