Skip to content

Adjust to use DBAL type#1664

Merged
mvorisek merged 16 commits intodevelopfrom
adjust_dbal_type
Sep 30, 2021
Merged

Adjust to use DBAL type#1664
mvorisek merged 16 commits intodevelopfrom
adjust_dbal_type

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Sep 29, 2021 •
edited
Loading

for atk4/data#727 change

marking as bug & BC-break as DateTime handling was buggy and not only managed values should be set in PHP

Also improve:

  • Callback exception are caught in order to suppress ultra-hard-to-debug Callback requested, but never reached errors
  • Behat testing, exceptions are now parsed from HTML and dumped

callback exceptions before:

image

callback exceptions after:

image

DarkSide666
DarkSide666 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approved

@mvorisek mvorisek marked this pull request as ready for review September 29, 2021 23:19
@mvorisek mvorisek force-pushed the adjust_dbal_type branch 8 times, most recently from 57312a2 to 498dca2 Compare September 30, 2021 17:50
@mvorisek mvorisek force-pushed the adjust_dbal_type branch 2 times, most recently from 63fdb8d to a66930f Compare September 30, 2021 19:15
@mvorisek mvorisek force-pushed the adjust_dbal_type branch 2 times, most recently from ce3f129 to d852f51 Compare September 30, 2021 19:34
@mvorisek mvorisek force-pushed the adjust_dbal_type branch 3 times, most recently from 8f46f32 to b47e4c3 Compare September 30, 2021 19:58
@mvorisek mvorisek force-pushed the adjust_dbal_type branch 2 times, most recently from d0017d6 to 7d53565 Compare September 30, 2021 20:50
@mvorisek mvorisek added RTM and removed MAJOR labels Sep 30, 2021
@mvorisek mvorisek merged commit f1e82fe into develop Sep 30, 2021
@mvorisek mvorisek deleted the adjust_dbal_type branch September 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@ibelar ibelar Awaiting requested review from ibelar

@georgehristov georgehristov Awaiting requested review from georgehristov

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

Assignees

No one assigned

Labels

BC-break bug 🪲 RTM

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek @DarkSide666