Skip to content

Refactor callback url test#1662

Merged
mvorisek merged 2 commits intodevelopfrom
refactor_callback_url_test
Sep 27, 2021
Merged

Refactor callback url test#1662
mvorisek merged 2 commits intodevelopfrom
refactor_callback_url_test

Conversation

@mvorisek
Copy link
Copy Markdown
Member

pure refactoring changes from #1651

@mvorisek mvorisek force-pushed the refactor_callback_url_test branch from 3cf82a8 to 238d33f Compare September 25, 2021 16:36
@mvorisek mvorisek requested a review from ibelar September 25, 2021 16:39
@mvorisek mvorisek force-pushed the refactor_callback_url_test branch from 90880f3 to 40e855f Compare September 25, 2021 16:40
@mvorisek mvorisek marked this pull request as ready for review September 25, 2021 16:42
@mvorisek mvorisek added the RTM label Sep 25, 2021
$this->simulateCallbackTriggering($cb);

$expectedUrlCbApp = '?' . Callback::URL_QUERY_TRIGGER_PREFIX . 'aa=callback&' . Callback::URL_QUERY_TARGET . '=aa';
$expectedUrlCb = '?' . /*Callback::URL_QUERY_TRIGGER_PREFIX . 'aa=1&' .*/ Callback::URL_QUERY_TRIGGER_PREFIX . 'bb=callback&' . Callback::URL_QUERY_TARGET . '=bb';
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test of the current/wrong behaviour, will be fixed in #1651

Copy link
Copy Markdown
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 5d33fc2 into develop Sep 27, 2021
@mvorisek mvorisek deleted the refactor_callback_url_test branch September 27, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants