Skip to content

Feature/Panel Action Executor#1650

Merged
ibelar merged 62 commits intodevelopfrom
feature/panel-executor
Oct 5, 2021
Merged

Feature/Panel Action Executor#1650
ibelar merged 62 commits intodevelopfrom
feature/panel-executor

Conversation

@ibelar
Copy link
Copy Markdown
Contributor

@ibelar ibelar commented Jul 15, 2021

Another option instead of using Modal for executing Data\UserAction.

  • Will play step within the Right panel.

Merge after #1646

$factory = $app->getExecutorFactory();
$factory->registerTypeExecutor($factory::STEP_EXECUTOR, [PanelExecutor::class]);

Screen Shot 2021-07-15 at 5 03 17 PM

Screen Shot 2021-07-15 at 4 56 07 PM

@ibelar ibelar marked this pull request as ready for review July 25, 2021 14:59
src/CardDeck.php Outdated
if ($this->paginator !== false) {
$this->addPaginator();
$this->stickyGet($this->paginator->name);
$this->issetApp() ? $this->getApp()->stickyGet($this->paginator->name) : $this->stickyGet($this->paginator->name);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need global sticky?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove!

@ibelar ibelar merged commit 4bf8f12 into develop Oct 5, 2021
@ibelar ibelar deleted the feature/panel-executor branch October 5, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants