Feature/Virtual Page Action Executor#1649
Merged
Conversation
mvorisek
reviewed
Jul 19, 2021
mvorisek
approved these changes
Jul 26, 2021
Member
mvorisek
left a comment
There was a problem hiding this comment.
I checked only the URL building, which seems ok now
|
|
||
| if ($this->paginator !== false) { | ||
| $this->addPaginator(); | ||
| $this->stickyGet($this->paginator->name); |
Member
There was a problem hiding this comment.
if removed, does Behat testing fails?
Contributor
Author
There was a problem hiding this comment.
there is no behat test for Card deck with either VpExecutor or new PanelExecutor. This is because the default executor register in ExecutorFactory is ModalExecutor. I can added tests but we need a way to be able to switch executor types dynamically. Any idea? Should we switch base on GET argument in init-app?
Member
There was a problem hiding this comment.
I meant if sticky args in Card Deck are tested.
with either VpExecutor or new PanelExecutor...
I belive this does not need extra cross testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modal executors can be problematic sometimes on Mobile devices. This PR will added options to use a VirtualPage Executor instead which is more mobile-friendly.
In order to change executor type, simply register the new class for Model\UserAction
Executor preview:
Executor in arguments step:
Executor in fields step:
Executor in preview step:
