[fix] registerExecutor parameter type#1613
Merged
Conversation
Allow to use Object instance as seed.
mvorisek
approved these changes
Apr 8, 2021
Member
|
merged but the seed object is not instanced neewly, thus allowing object seed in general may lead to very strange results, be careful |
Contributor
Author
|
Is it better to check for proper instance then and throw error if not array and not of type ExecutorInterface? |
Member
|
Phpstan will do this check if enabled in project where used. The issue is when you pass some object seed, that is expected to be instanced for every use. |
Contributor
Author
|
yes right, I misunderstood your comment. Perhaps check should be at the object creation in order to make sure the created instance if of type ExecutorInterface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using Object instance as seed.