Merged
Conversation
mvorisek
reviewed
Feb 2, 2021
mvorisek
reviewed
Feb 2, 2021
mvorisek
reviewed
Feb 2, 2021
mvorisek
reviewed
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1587
The callback
Callback::set()method needs to be called prior to VirtualPage::getHtml() method in order for other's callback inside VirtualPage to be execute properly.BC Break
Property
$fxwas remove and no longer necessary becauseCallback::set()method is called during VirtualPage::set() and not duringVirtualPage::getHtml()as before. This is to ensure thatCallback::set()is always run.Therefore, using DI to set $fx property via
VirtualPage::addTo($app, ['fx' => function(){}])is no longer supported.Virtual::Page::set() only accept \Closure instead of callable as before. You must convert your callable into Closure via \Closure::fromCallable()