Skip to content

Use also different actual name#1593

Merged
mvorisek merged 1 commit intodevelopfrom
fix_actual_bugs
Feb 25, 2021
Merged

Use also different actual name#1593
mvorisek merged 1 commit intodevelopfrom
fix_actual_bugs

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Jan 20, 2021 •
edited
Loading

No description provided.

@mvorisek mvorisek marked this pull request as draft January 20, 2021 11:59
@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Jan 20, 2021

@georgehristov seems atk4/data does not resolve their_field etc. correctly (using model's actual). Would you like to help with this?

@georgehristov
Copy link
Copy Markdown
Collaborator

georgehristov commented Jan 20, 2021

@mvorisek yes, I will have a look

DarkSide666
DarkSide666 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mvorisek mvorisek marked this pull request as ready for review January 20, 2021 14:06
@mvorisek mvorisek mentioned this pull request Jan 20, 2021
Merged
@mvorisek mvorisek force-pushed the fix_actual_bugs branch 4 times, most recently from 85a3f8b to 2c303f8 Compare February 22, 2021 23:03
@mvorisek mvorisek force-pushed the fix_actual_bugs branch 3 times, most recently from bb2fd56 to 9b00dd5 Compare February 22, 2021 23:23
@mvorisek mvorisek merged commit 161a878 into develop Feb 25, 2021
@mvorisek mvorisek deleted the fix_actual_bugs branch February 25, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov georgehristov approved these changes

@ibelar ibelar Awaiting requested review from ibelar

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvorisek @georgehristov @DarkSide666