Skip to content

[fix] Id generation when using Executor as Modal View#1575

Merged
mvorisek merged 6 commits intodevelopfrom
fix/modal-executor-id
Jul 26, 2021
Merged

[fix] Id generation when using Executor as Modal View#1575
mvorisek merged 6 commits intodevelopfrom
fix/modal-executor-id

Conversation

@ibelar
Copy link
Copy Markdown
Contributor

@ibelar ibelar commented Dec 18, 2020

Remove special characters, like dot, from table name when generating View::id.

@PhilippGrashoff
Copy link
Copy Markdown
Collaborator

am curious: why is the table name needed at all?

@ibelar
Copy link
Copy Markdown
Contributor Author

ibelar commented Dec 18, 2020

am curious: why is the table name needed at all?

If I remember correctly, it was because of callback issues.
Modal view are generated outside their parent and since Executor are using modal and related on their name or id to carry the model id being used by the action, it was causing issue when executor was create from a reload.
That why we needed a way to make sure Modal name (id) was the same for each Model user action, with no regards to their location in the render tree.

@ibelar ibelar added the RTM label Dec 18, 2020
@ibelar ibelar requested a review from DarkSide666 December 23, 2020 15:38
@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Jan 6, 2021

seems not abstract enough, how name is build normally, is there a method for it?

@mvorisek
Copy link
Copy Markdown
Member

So executor with a non unique name is put to some non-unique render tree?

This should have a Behat test.

@mvorisek mvorisek removed the RTM label May 12, 2021
@mvorisek mvorisek merged commit 9773025 into develop Jul 26, 2021
@mvorisek mvorisek deleted the fix/modal-executor-id branch July 26, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants