[fix] Id generation when using Executor as Modal View#1575
Merged
Conversation
Collaborator
|
am curious: why is the table name needed at all? |
Contributor
Author
If I remember correctly, it was because of callback issues. |
Member
|
seems not abstract enough, how name is build normally, is there a method for it? |
Member
|
So executor with a non unique name is put to some non-unique render tree? This should have a Behat test. |
Executor is no longer attached to html view.
mvorisek
reviewed
Jul 26, 2021
mvorisek
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove special characters, like dot, from table name when generating View::id.