[fix] Property access for Modal Executor#1565
Merged
DarkSide666 merged 1 commit intodevelopfrom Dec 9, 2020
Merged
Conversation
- Allow private property access. Usefull when creating special form in Modal Executor.
Collaborator
|
Talking about private, wdyt about #1537? I think putting a lot of private in our code makes it less extendable and customizable. IMO private should only be used over protected when there is a very good reason for it. |
mvorisek
reviewed
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow private property access.
Useful when a special form is needed in Modal Executor.