Skip to content

[fix] Card Deck demo#1552

Merged
DarkSide666 merged 4 commits intodevelopfrom
fix/card-deck-demo
Dec 4, 2020
Merged

[fix] Card Deck demo#1552
DarkSide666 merged 4 commits intodevelopfrom
fix/card-deck-demo

Conversation

@ibelar
Copy link
Copy Markdown
Contributor

@ibelar ibelar commented Dec 1, 2020

  • Fix issue where title field may appears twice in Card;

Before:
Screen Shot 2020-12-01 at 4 11 45 PM

After:

Screen Shot 2020-12-01 at 4 11 21 PM

Other

  • move some demo file
    • Card deck now in the data collection section;
    • Drag n drop now in the interactive section

- Fix issue where title field appear twice;
- move some demo file
  - Card deck now in data collection section;
  - Drag n drop now in interactive section
@DarkSide666 DarkSide666 self-requested a review December 2, 2020 11:09
@DarkSide666
Copy link
Copy Markdown
Member

xdebug issue, should wait while that is fixed in develop branch, merge in and rerun tests

@ibelar ibelar added the RTM label Dec 2, 2020
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit b55ddbc into develop Dec 4, 2020
@DarkSide666 DarkSide666 deleted the fix/card-deck-demo branch December 4, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants