Fix missing DIContainerTrait when StaticAddToTrait is used#1251
Merged
mvorisek merged 1 commit intoatk4:developfrom Jun 7, 2020
mvorisek:fix_for_new_factory
Merged
Fix missing DIContainerTrait when StaticAddToTrait is used#1251mvorisek merged 1 commit intoatk4:developfrom mvorisek:fix_for_new_factory
mvorisek merged 1 commit intoatk4:developfrom
mvorisek:fix_for_new_factory
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1251 +/- ##
==========================================
Coverage 72.35% 72.35%
Complexity 2556 2556
==========================================
Files 130 130
Lines 6313 6313
==========================================
Hits 4568 4568
Misses 1745 1745
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor code for atk4/core#221
fully documented behaviour that DIContainerTrait trait much be used when StaticAddToTrait is used