-
Notifications
You must be signed in to change notification settings - Fork 111
Crud bug on dynamically disabled rows #2212
Copy link
Copy link
Closed
Labels
Description
Crud's ActionsButtons can be set either statically disabled or enabled, or dynamically a) via a passed function via $isDisabled parameter or b) via a dynamically set UserAction->enabled = function ($row) ....
There is however a logical error in
ui/src/Table/Column/ActionButtons.php
Line 65 in 2e27a15
| $this->isEnabledFxs[$name] = $isDisabled; |
as $this->isEnabledFxs[$name] = $isDisabled; This has to be the negation - or we call $isDisabled better $isEnabled an change references. I am in favor of this, as Atk4\Model always refers to "enabled" and not "disabled".
Let me know, then we can change all $isDisabled to $isEnabled in Atk4\Ui together.
Reactions are currently unavailable