Conversation
mvorisek
reviewed
May 9, 2021
phpstan.neon.dist
Outdated
| # TODO these rules are generated, this ignores should be fixed in the code | ||
| # level 0 | ||
| - | ||
| message: "#^Class Atk4\\\\Ui\\\\Persistence\\\\UI not found\\.$#" |
Member
There was a problem hiding this comment.
these errors must be definitely fixed
I can then look at the at burn and lowest test.
mvorisek
reviewed
May 11, 2021
Member
|
@abbadon1334 Any chance you could finalize this PR and make it compatible with ATK 3.0 ? |
Collaborator
Author
sure @DarkSide666, what you think if, we release this for 2.4.0 ( see you what you do with failing new tests), and after that work on release for 3.0. I hope I don't have the same issues with the tests in 3.0 |
Member
That sounds like a plan. |
…date-release-workflow
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.