This repository was archived by the owner on Aug 16, 2022. It is now read-only.
Add build testing to GH#27
Merged
romaninsh merged 11 commits intoatk4:masterfrom Jan 19, 2021
mvorisek:test_in_gh_actions
Merged
Add build testing to GH#27romaninsh merged 11 commits intoatk4:masterfrom mvorisek:test_in_gh_actions
romaninsh merged 11 commits intoatk4:masterfrom
mvorisek:test_in_gh_actions
Conversation
Merged
This was referenced Jan 16, 2021
romaninsh
approved these changes
Jan 19, 2021
Member
romaninsh
left a comment
There was a problem hiding this comment.
approved - but please add more info on running "make.php" into README - for local testing.
|
|
||
| ## Running Locally | ||
|
|
||
| Run `make build` to regenerate Dockerfiles and to rebuild all docker images. Check "Makefile" for more details |
Member
There was a problem hiding this comment.
if you are replacing make with "make.php" could you mention that in the README instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18