Fix numeric compare affinity for SQLite#989
Merged
Conversation
f3bc2d8 to
c7b3b9d
Compare
5c18e4b to
b5d0903
Compare
5910acb to
2b639aa
Compare
2b639aa to
dcad20f
Compare
781b4ea to
a5c4309
Compare
e2f26c5 to
830fc0b
Compare
93161aa to
5ceb93a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #950
in theory, the fix should be done on whole SQL AST, but such approach requires AST parser, so for simplicity, the fix is done on comparison expressions created using
Query::where()method only