Conversation
73f2c4d to
ec9b725
Compare
7084258 to
d91be39
Compare
mvorisek
commented
Jan 16, 2022
| * Create fake foreign model, in the future, this method should be removed | ||
| * in favor of always requiring an object model. | ||
| */ | ||
| protected function createFakeForeignModel(): Model |
Member
Author
There was a problem hiding this comment.
FYI if foreign model hooks needs to be executed, override this method to provide non-faked Model for $this->foreign_table table
41eb3ab to
8e96c32
Compare
DarkSide666
reviewed
Jan 18, 2022
6bf1018 to
b3000b3
Compare
9c624eb to
11baf74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
take advantage of #946 and #961
and fix #955 (model is still faked, or
Model\Join::createFakeForeignModel()method needs to be overridden to return non-faked model with real hooks)