Skip to content

Deduplicate Reference from entity#915

Merged
mvorisek merged 10 commits intodevelopfrom
nonentity_ref
Nov 11, 2021
Merged

Deduplicate Reference from entity#915
mvorisek merged 10 commits intodevelopfrom
nonentity_ref

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Nov 11, 2021

BC break

Reference is no longer bound to an entity, thus methods Reference::ref, Field::refModel, Field::refLink requires entity provided as the 1st argument like $ref->ref($entity). No change required if traversing from model/entity directly.

@mvorisek mvorisek marked this pull request as ready for review November 11, 2021 21:31
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvorisek mvorisek merged commit 54c8d07 into develop Nov 11, 2021
@mvorisek mvorisek deleted the nonentity_ref branch November 11, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants