Rename "money" type to "atk4_money" type#895
Merged
Conversation
7b8e737 to
65c5ecf
Compare
b6ded82 to
a0651ef
Compare
DarkSide666
approved these changes
Oct 1, 2021
a0651ef to
4cfea0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBAL types are global and by including this library within composer generic
moneytype should not be added to other projects.To keep this type we rename it to
atk4_money. This type represents basic float type with rounding to 4 decimal places.We also drop
passwordtype as it does not provide any security. Password securtiy should be implemented usingstringtype on higher app level.newly, when no
Field::typeis set, the value is normalized usingstringtypeAtk4\Schema\PhpunitTestCaseclass renamed toAtk4\Data\Schema\TestCaseAtk4\Schema\Migrationclass renamed toAtk4\Data\Schema\Migrationalso adjust for renamed Hintable package name