HasOneSql::addField(): Use type from reference Model#880
Merged
mvorisek merged 4 commits intoatk4:developfrom Jul 12, 2021
Merged
Conversation
97e1c8d to
1363857
Compare
…eTypeFromReferenceModel
Contributor
Author
|
RTM, can't assign labels |
mvorisek
approved these changes
Jul 12, 2021
This was referenced Aug 25, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
currently, the type of a field is not taken from the referenced model (unlike Caption, this is already pulled from the referenced Model). This leads to:
at this point, ModelBs field 'some_date' is of type string, not of type date as defined in ModelA. This PR would change this.