Skip to content

Test with limited max. connections#878

Merged
mvorisek merged 1 commit intodevelopfrom
test_with_limited_mysql_max_connections
Jun 14, 2021
Merged

Test with limited max. connections#878
mvorisek merged 1 commit intodevelopfrom
test_with_limited_mysql_max_connections

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented May 12, 2021 •
edited
Loading

related with sebastianbergmann/phpunit#4705

mysql_close call seems to be not always synchronous, so use limit of 5

related with php/php-src#5581

@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from 9467d90 to 971b1e1 Compare May 25, 2021 11:48
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch 10 times, most recently from 9396d64 to 3a23c34 Compare June 9, 2021 08:50
@mvorisek mvorisek marked this pull request as draft June 9, 2021 08:51
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch 6 times, most recently from 369a080 to 24bcd1a Compare June 10, 2021 18:33
@mvorisek mvorisek marked this pull request as ready for review June 10, 2021 18:35
@mvorisek mvorisek changed the title Test MySQL with limited max_connections Test MySQL with limited max_connections to 2 Jun 10, 2021
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch 2 times, most recently from 9fea50e to 222d452 Compare June 10, 2021 19:00
@mvorisek mvorisek requested a review from abbadon1334 June 10, 2021 19:01
@mvorisek mvorisek added RTM Tests and removed RTM labels Jun 10, 2021
@mvorisek mvorisek changed the title Test MySQL with limited max_connections to 2 Test MySQL with limited max_connections to 3 Jun 11, 2021
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from 09005aa to cf967c3 Compare June 11, 2021 09:30
@mvorisek mvorisek added the RTM label Jun 11, 2021
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from cf967c3 to 5750e7b Compare June 11, 2021 09:36
@mvorisek mvorisek changed the title Test MySQL with limited max_connections to 3 Test MySQL with limited max_connections to 5 Jun 11, 2021
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from 63ae25d to 45450ea Compare June 11, 2021 11:24
@mvorisek mvorisek marked this pull request as draft June 11, 2021 15:20
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch 3 times, most recently from 4e16dca to 6376b21 Compare June 13, 2021 12:12
@mvorisek mvorisek changed the title Test MySQL with limited max_connections to 5 Test with limited max. connections Jun 13, 2021
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch 2 times, most recently from e76a7f2 to 558599b Compare June 13, 2021 21:43
@mvorisek mvorisek marked this pull request as ready for review June 13, 2021 21:43
@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from 558599b to 7710384 Compare June 14, 2021 09:26
@mvorisek mvorisek requested review from DarkSide666, abbadon1334 and georgehristov and removed request for DarkSide666, abbadon1334 and georgehristov June 14, 2021 09:27
abbadon1334
abbadon1334 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek force-pushed the test_with_limited_mysql_max_connections branch from 7710384 to de0fe3f Compare June 14, 2021 14:34
@mvorisek mvorisek merged commit 982ea82 into develop Jun 14, 2021
@mvorisek mvorisek deleted the test_with_limited_mysql_max_connections branch June 14, 2021 14:34
@mvorisek mvorisek mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbadon1334 abbadon1334 abbadon1334 approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees

No one assigned

Labels

RTM Tests

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek @abbadon1334