Array persistence store with strict objects#860
Merged
Conversation
4bfe15e to
8932fd3
Compare
247042e to
6be75ee
Compare
32d742a to
977f0d5
Compare
6472766 to
e03742b
Compare
This was referenced Apr 22, 2021
d13bb72 to
59892e0
Compare
59892e0 to
63a93e5
Compare
mvorisek
commented
Apr 23, 2021
| 7 => ['name' => 'ABC3', 'code' => 17, 'country' => 'Latvia', 'active' => 0], | ||
| 8 => ['name' => 'ABC2', 'code' => 18, 'country' => 'Russia', 'active' => 1], | ||
| 9 => ['code' => 19, 'country' => 'Latvia', 'active' => 1], | ||
| 9 => ['name' => null, 'code' => 19, 'country' => 'Latvia', 'active' => 1], |
Member
Author
There was a problem hiding this comment.
this PR always make sure the data are rectangular, a positive side effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are minor BC breaks like renamed array Action class, but these are normally not used by the end user thus the changes should be BC, also no changes in atk4/ui required or it was a bug previously.
Fixes several bugs like non strictly rectangular data, Array persistence throw if update is called on non existing ID...