Conversation
993a7a8 to
4b3d4e8
Compare
cae8520 to
fd22962
Compare
20e6c91 to
a148ab1
Compare
DarkSide666
approved these changes
Apr 7, 2021
| { | ||
| if ($id !== self::ID_LOAD_ANY) { | ||
| throw new \Error/*Exception*/ ('CSV Persistence does not support other than LOAD ANY mode'); // @TODO we can iterate... | ||
| throw new Exception('CSV Persistence does not support other than LOAD ANY mode'); // @TODO |
Member
There was a problem hiding this comment.
lost comment "we can iterate"
Member
Author
There was a problem hiding this comment.
we can iterate was introduced by me yesterday, today I removed it, by ìterate I meant another PR which I found a little confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish after #846