Skip to content

Remove ui property from UserAction#843

Merged
ibelar merged 2 commits intodevelopfrom
no-ui-usage
Mar 26, 2021
Merged

Remove ui property from UserAction#843
ibelar merged 2 commits intodevelopfrom
no-ui-usage

Conversation

@mvorisek
Copy link
Copy Markdown
Member

finish after atk4/ui#1550

@mvorisek
Copy link
Copy Markdown
Member Author

@ibelar please finish this PR related to the ui PR

I tried to delete all ui props from this data repo, but there are quite a lot of uses and I am not sure if all of them can be removed...

@mvorisek mvorisek marked this pull request as ready for review March 26, 2021 13:21
@mvorisek mvorisek changed the title Uncouple atk4/ui usage Remove ui property from UserAction Mar 26, 2021
@ibelar
Copy link
Copy Markdown
Contributor

ibelar commented Mar 26, 2021

@mvorisek - I have removed UserAction ui property setting from Model.
I have also delete the $ui property from UserAction Class. Was not sure if we should keep it for backward compatibility or not and mark it as obsolete. If so, please add it back.

@mvorisek
Copy link
Copy Markdown
Member Author

I have also delete the $ui property from UserAction Class. Was not sure if we should keep it for backward compatibility or not and mark it as obsolete. If so, please add it back.

removing is ok as it will go hand in hand with 2.4 ui rel

please approve/merge this PR, the changes are from you, but I am the initiating author and can not merge it...

Copy link
Copy Markdown
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibelar ibelar merged commit 66b7318 into develop Mar 26, 2021
@ibelar ibelar deleted the no-ui-usage branch March 26, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants