Add additional Join test with field actual names and prefixes#834
Add additional Join test with field actual names and prefixes#834DarkSide666 merged 2 commits intodevelopfrom
Conversation
| $this->assertEquals( | ||
| [ | ||
| 'user' => [ | ||
| 1 => ['id' => 1, 'first_name' => 'John 2', 'cid' => 1], |
There was a problem hiding this comment.
I belive this is wrong, as actual name should be used for low level SQL only, otherwise field name (not actual name) should be used.
This line should be:
1 => ['id' => 1, 'first_name' => 'John 2', 'contact_id' => 1],
There was a problem hiding this comment.
Not really. This is just direct dump from DB, so there will be actual names here.
There was a problem hiding this comment.
You are right, but in export and other non-low-level dumps it should not have the actual name.
There was a problem hiding this comment.
yes in import / export should not have actual names.
But as you see in Join class it still will use actual names when linking tables. See I added comment there in this PR.
I don't think we have to change that, but having additional note about that could be good.
mvorisek
left a comment
There was a problem hiding this comment.
join use actual only, but that seems enough for now....
No description provided.