Merged
Conversation
a8f56de to
da006b0
Compare
Collaborator
georgehristov
left a comment
There was a problem hiding this comment.
This version I like
src/Reference/HasMany.php
Outdated
| ->addMoreInfo('their_fallback_field', $theirField); | ||
| } | ||
|
|
||
| return $theirField; |
Collaborator
There was a problem hiding this comment.
Maybe assign it to $this->their_field?
Collaborator
There was a problem hiding this comment.
And rename $theirField to $theirFieldName for consistency...
Member
Author
There was a problem hiding this comment.
no - we should not materialize guesses if not done on construction time
georgehristov
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Join has simillar guessing, but as it operates on
foreign_tableinstead of Model, we can not check early there