Skip to content

Table must be specified with table key in defaults#819

Merged
mvorisek merged 6 commits intodevelopfrom
no_str_default_table
Dec 29, 2020
Merged

Table must be specified with table key in defaults#819
mvorisek merged 6 commits intodevelopfrom
no_str_default_table

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Dec 29, 2020

No description provided.

@mvorisek mvorisek marked this pull request as draft December 29, 2020 22:26
DarkSide666
DarkSide666 approved these changes Dec 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix tests appropriately.

@mvorisek mvorisek marked this pull request as ready for review December 29, 2020 23:28
@mvorisek mvorisek force-pushed the no_str_default_table branch from 3ffad24 to 4a6df0f Compare December 29, 2020 23:31
@mvorisek mvorisek force-pushed the no_str_default_table branch 2 times, most recently from 9772945 to b2846b3 Compare December 29, 2020 23:40
@mvorisek mvorisek force-pushed the no_str_default_table branch 2 times, most recently from 83aaeab to 2fc0de3 Compare December 29, 2020 23:44
@mvorisek mvorisek force-pushed the no_str_default_table branch from 2fc0de3 to 41b11e5 Compare December 29, 2020 23:49
@mvorisek mvorisek merged commit c4eebb4 into develop Dec 29, 2020
@mvorisek mvorisek deleted the no_str_default_table branch December 29, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees

No one assigned

Labels

BC-break

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek @DarkSide666